task: adds drush install/remove bypass for drupal main branch #61#62
Merged
task: adds drush install/remove bypass for drupal main branch #61#62
Conversation
Member
|
We can wait just a hair for this one as there is sudden movement on drush. |
Contributor
Author
|
+1. We should probably make a decision by Monday or Tuesday giving time to check-in with discussions in contribution room/lounge. |
Member
|
I'll probably pull and experiment with it today on train. |
Authored by: mradcliffe
rfay
force-pushed
the
61-drush-alternative
branch
from
2e2eef2 to
e794e65
Compare
…l install instructions, fixes ddev#61 - Fix syntax error: missing closing quote on DRUPAL_BRANCH != "main" condition - Fix if/else structure: restore 'else' guard so Steps 5-6 are skipped on SETUP_FAILED - Add Step 4.1: ddev composer remove drush/drush on main branch before any composer update/install - Simplify Step 5: drush install/removal logic now clean (main handled in 4.1) - Step 6: skip ddev drush si on main branch (not yet compatible); set MANUAL_INSTALL_NEEDED - Append manual install instructions to WELCOME.txt with site URL when on main branch - Skip ddev drush cr when Drupal is not installed (MANUAL_INSTALL_NEEDED=true) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
drush/drush and drupal/core-recommended conflict due to Symfony 8.
How This PR Solves The Issue
Prevents drush from being installed or removes drush when DRUPAL_BRANCH is main so that composer install will work.
This means that any further drush commands will fail, and Drupal will need to be installed via the user interface.
Adds a todo to follow-up and either revert this code or change to using a future core CLI command. Hopefully that is done in the next 3-6 months.
Manual Testing Instructions
I am not sure how to manually test since I am new to coder-ddev.
Automated Testing Overview
Hopefully the "::main:drupal12" test will pass.
Related Issue Link(s)
#61
Release/Deployment Notes